On Wed, 27 Jul 2022 09:45:25 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> Currently the `RegisterMap` constructor uses implicit boolean arguments to
>> configure its function. Implicit boolean arguments makes code harder to
>> understand and reason about at the call site. Using explicit scoped enums
>> instead makes it both clear what is being configured and the type safety
>> makes mistakes less likely.
>>
>> Update `RegisterMap` constructors to use these scoped enum types instead of
>> booleans.
>> ```C++
>> enum class UpdateMap { skip, yes };
>> enum class ProcessFrames { skip, yes };
>> enum class WalkContinuation { skip, yes };
>>
>>
>> Testing: tier1-3
>
> Axel Boldt-Christmas has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Rename yes to include
Lgtm. Thanks.
-------------
Marked as reviewed by tschatzl (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9455
