On Thu, 25 Aug 2022 03:31:03 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> SA has the following source directory: > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/proc > > However, there are no references to any classes in this directory. There used > to be a reference to ProcDebuggerLocal, but this reference was removed, along > with the class, when solaris support was removed by > [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). There appears to > be no other need for anything in this directory now, and I believe it can be > safely removed. A lot of files 8-) 3 files in riscv64 were surprising to me, as they are new, from: 8276799: Implementation of JEP 422: Linux/RISC-V Port But there are "non-proc" versions of the RISCV64 files, and I don't see any references to the /proc/ files that were added. e.g. sun/jvm/hotspot/debugger/linux/riscv64/LinuxRISCV64CFrame uses RISCV64ThreadContext, and LinuxCDebugger uses RISCV64ThreadContext. These might have been added due to honourably mirroring what other platforms had, although they aren't needed, so this looks good. ------------- Marked as reviewed by kevinw (Committer). PR: https://git.openjdk.org/jdk/pull/10013
