On Thu, 15 Sep 2022 22:27:25 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Redundant castings make code harder to read. >> Found them by IntelliJ IDEA. >> I tried to choose only casts which are definitely safe to remove. >> Most generification was done in >> [JDK-8241618](https://bugs.openjdk.org/browse/JDK-8241618), but casts >> weren't removed. > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GenCollectedHeap.java > line 134: > >> 132: } else { >> 133: return VMObjectFactory.newObject(GenerationSpec.class, >> 134: oldGenSpecField.getAddress()); > > Maybe make each of these one line instead of two. Other lines in this file don't exceed 80 chars. So, I think it's better to preserver line break here. ------------- PR: https://git.openjdk.org/jdk/pull/10295
