On Wed, 4 Jan 2023 13:04:10 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some >> circumstances a negative rmiport (--rmiport -1) to SALauncher.java. >> This leads to a somewhat misleading message >> `[debugd] Argument is expected for 'rmiport' ` >> (we set an argument [-1] but probably this is not what is really expected) >> and additionally the real exception is not shown. >> Probably also a warning in case of negative rmiport values should be printed >> because they seem to lead to errors. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Adjust Copyright years, omit one output line SADebugDTest is only one test, so seems OK to have it fail as soon as we realise we need a port, and it has a value of -1. I would do it in this change as they are so connected, but really whichever works best for you. (I don't see other uses of findUnreservedFreePort() in the same test hierarchy, so this task should not keep on growing... 8-) ) ------------- PR: https://git.openjdk.org/jdk/pull/11811
