> This test fails sometimes with ZGC. It is testing using Panama to access > Windows' last error value, and can of course be interrupted by VM work that > changes the value, but it does generally work. Skipping the test with ZGC is > reasonable as you don't really _have_ to step through this kind of Panama > code with ZGC. > > More rare is a failure where "The application exited" is not observed. This > test is not here to test the exit mode, and logging that failure avoids > telling you whether the correct lastError value was seen. Test should > prioritise saying if the correct last error value was observed, and should > check for the exception being thrown when the correct value is not seen.
Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: exception message update ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12441/files - new: https://git.openjdk.org/jdk/pull/12441/files/e37f1e73..bbe811be Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12441&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12441&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12441.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12441/head:pull/12441 PR: https://git.openjdk.org/jdk/pull/12441
