On Thu, 5 Jan 2023 03:01:22 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Yi Yang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains two >> new commits since the last revision: >> >> - separate renaming >> - 8299518: HotSpotVirtualMachine shared code across different platforms > > I like the approach in general. > Also, I agree with David on his comments, especially on the renaming. > The abstract methods `readImpl()` and `closeImpl()` is better to name as > `read()` and `close()`. @sspitsyn @dholmes-ora @turbanoff May I ask your help to review this patch? Thanks. ------------- PR: https://git.openjdk.org/jdk/pull/11823
