On Sun, 16 Apr 2023 08:06:32 GMT, Alan Bateman <al...@openjdk.org> wrote:

> The observer calling java.lang.management.ThreadInfo::getStackTrace could 
> sample the thread in Thread.sleep at any time so I think it may see 
> afterSleep in the stack.

Thanks @AlanBateman  -Yes, sorry, the test doesn't do what I expected - the 
sleep is actually incidental so it copuld be sampled anywhere.

> and add the two SleepEvent methods to the expected list.

I see now those two methods are already present, so just the stack depth check 
needs updating.

Of course if this test were ever run with these events enabled then it could 
fail for a variety of reasons.

BTW the comments in TestDescription.java for strace00* are all inaccurate  with 
regards to this:

 2. The length of a trace must not be greater than (depth + 3).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13476#issuecomment-1510571422

Reply via email to