On Thu, 6 Apr 2023 14:38:20 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> RISCV update
>
> src/hotspot/share/services/management.cpp line 1131:
>
>> 1129: if (maxDepth == 0) {
>> 1130: // No stack trace to dump so we do not need to stop the world.
>> 1131: // Since we never do the VM op here we must set the threads list.
>
> You may want to add a little more to this comment after L1131:
>
> // Since we are not stopping the world, the data we gather here
> // may change the moment after we return it.
Nit: even if you are stopping the world you have restarted it by the time you
return so the data can change anyway.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10907#discussion_r1172177158
