On Fri, 5 May 2023 23:53:47 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> The SA document `transported_core.html` contains some tips on getting core > files to work when debugging it on a machine other than the one that produced > it. There are a few improvements that can be made based on information > provided in [JDK-8306437](https://bugs.openjdk.org/browse/JDK-8306437) and in > the #13836 review (which was eventually pulled as not necessary). > > Updates to the document include the use of > `sun.jvm.hotspot.debugger.windbg.imagePath` and > `sun.jvm.hotspot.debugger.windbg.symbolPath` properties, and adding > "`srv*https://msdl.microsoft.com/download/symbols`"; to symbolPath. > > The rendered html file with these changes can be found here: > https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk/baa6b36cd5b9c5b953fd9f5b8f4461bd4107ee05/src/jdk.hotspot.agent/doc/transported_core.html Looks good. Posted one comment about a potential typo. Thanks, Serguei src/jdk.hotspot.agent/doc/transported_core.html line 94: > 92: > 93: <p> > 94: How you set these properties will depend on the SA tool being used. The > following in an example of when launching the clhsdb tool: Typo?: `The following in an example of when launching...` => `The following is an example of launching...`. ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13849#pullrequestreview-1415750632 PR Review Comment: https://git.openjdk.org/jdk/pull/13849#discussion_r1186672347
