On Thu, 11 May 2023 07:19:47 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

> When using -Xcomp, the 5 second sleep in the debuggee main thread is not long 
> enough to guarantee using SIGTERM on the debuggee will make it exit(143) 
> before the main thread exits cleanly with exitValue 0. The easiest solution 
> is to just allow exitValue 0. See the CR for more details on other solutions 
> I rejected.

Reasonable compromise 8-)

passName doesn't get passed to InstTarg, otherwise it could wait at the end in 
the "Kill" case, as if we want to see a process exit in response to a SIGTERM, 
then that process needs to wait around.  But tolerating the signal not 
terminating it due to the race should be reliable also. 8-)

-------------

Marked as reviewed by kevinw (Committer).

PR Review: https://git.openjdk.org/jdk/pull/13923#pullrequestreview-1422323092

Reply via email to