On Tue, 16 May 2023 01:23:41 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> This is newly integrated test times out because it has a race in in the Test >> #A.1 and #A.2. >> The main root cause is a print statement which can case target virtual >> thread to unpark and unmount. >> This causes that the `StopThreads` unexpectedly fails with the >> `JVMTI_ERROR_OPAQUE_FRAME` error code. >> The target thread can be in some other unexpected states if JVMTI >> `StopThread` >> is called before the target thread method `A()` reached the synchronized >> statement. >> >> The fix is to replace the `ensureStarted()` with the `ensureAtPointA()`. >> The fix also includes some simplifications related to clearing the target >> thread interrupt status. >> >> Testing: >> Hundreds of mach5 runs of `serviceability/jvmti/vthread` tests which include >> the fixed `StopThreadTest`. >> TBD: To run mach5 tiers1-3. >> >> The test does not fail with this fix anymore. > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > moved Thread.interrupted() in StopThreadTest.java above a couple of lines Marked as reviewed by cjplummer (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/13969#pullrequestreview-1427568841
