On Thu, 11 May 2023 18:32:36 GMT, Guoxiong Li <[email protected]> wrote:
> Hi all, > > This patch revises the code of `ps_proc.c::process_get_lwp_regs` > to use `PTRACE_GETREGSET` first instead of `PTRACE_GETREGS`. > The `PTRACE_GETREGS` is not present on all architectures as the man page > states [1]. > And if we use `PTRACE_GETREGS` first, several tests will fail at the special > envs, > such as my local riscv64-linux env. Please see [the > issue](https://bugs.openjdk.org/browse/JDK-8307955) for more information. > > And I remove the unnecessary comments and macro, > because the `sparc` arch related code had been removed. > > Thanks for the review. > > Best Regards, > -- Guoxiong > > [1] https://man7.org/linux/man-pages/man2/ptrace.2.html Looks good to me. ------------- Marked as reviewed by kevinw (Committer). PR Review: https://git.openjdk.org/jdk/pull/13939#pullrequestreview-1428453553
