On Thu, 11 May 2023 18:32:36 GMT, Guoxiong Li <[email protected]> wrote:
> Hi all, > > This patch revises the code of `ps_proc.c::process_get_lwp_regs` > to use `PTRACE_GETREGSET` first instead of `PTRACE_GETREGS`. > The `PTRACE_GETREGS` is not present on all architectures as the man page > states [1]. > And if we use `PTRACE_GETREGS` first, several tests will fail at the special > envs, > such as my local riscv64-linux env. Please see [the > issue](https://bugs.openjdk.org/browse/JDK-8307955) for more information. > > And I remove the unnecessary comments and macro, > because the `sparc` arch related code had been removed. > > Thanks for the review. > > Best Regards, > -- Guoxiong > > [1] https://man7.org/linux/man-pages/man2/ptrace.2.html This pull request has now been integrated. Changeset: 2f1c6548 Author: Guoxiong Li <[email protected]> URL: https://git.openjdk.org/jdk/commit/2f1c65486b1e584f9c4a2eb7af2414d032a02748 Stats: 24 lines in 1 file changed: 9 ins; 13 del; 2 mod 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' Reviewed-by: cjplummer, kevinw ------------- PR: https://git.openjdk.org/jdk/pull/13939
