On Thu, 19 Jan 2023 17:23:19 GMT, Justin King <jck...@openjdk.org> wrote:
>> Remove abstraction that is a holdover from Solaris. Direct usages of >> `MmapArrayAllocator` have been switched to normal `malloc`. The >> justification is that none of the code paths are called from signal >> handlers, so using `mmap` directly does not make sense and is potentially >> slower than going through `malloc` which can potentially re-use memory >> without making any system calls. The remaining usages of `ArrayAllocator` >> and `MallocArrayAllocator` are equivalent. > > Justin King has updated the pull request incrementally with one additional > commit since the last revision: > > Do not pass nullptr to os::release_memory > > Signed-off-by: Justin King <jck...@google.com> Could we create a simpler version of this PR? One that only removes ArrayAllocator and ArrayAllocatorMallocLimit, but keeps MallocArrayAllocator and MmapArrayAllocator? That way we can figure out later, in a separate RFE, if we want to remove MmapArrayAllocator. ------------- PR Review: https://git.openjdk.org/jdk/pull/11931#pullrequestreview-1437268937
