On Thu, 1 Jun 2023 23:14:23 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: use output.shouldContain() > > test/jdk/sun/tools/jcmd/TestJcmdNoAgentLoad.java line 57: > >> 55: OutputAnalyzer output = JcmdBase.jcmd(jcmdArgs); >> 56: >> 57: assertEquals(output.getExitValue(), 0); > > I think tests normally just use `output.shouldHaveExitValue(0);` Thank you for the suggestion. I've derived this code from one of the existing jcmd tests. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14244#discussion_r1213871217
