On Tue, 6 Jun 2023 22:17:57 GMT, Alex Menkov <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: removed JVMTI_THREAD_STATE_RUNNABLE from a carrier thread state
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 768:
>
>> 766: }
>> 767: return state;
>> 768: }
>
> You don't need to call get_thread_state_base in case "passive carrier thread":
>
> if (is_passive_carrier_thread(jt, thread_oop)) {
> return JVMTI_THREAD_STATE_ALIVE | JVMTI_THREAD_STATE_WAITING
> | JVMTI_THREAD_STATE_WAITING_INDEFINITELY;
> }
> return get_thread_state_base(thread_oop, jt);
Thanks. Yes, noticed it. :) Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14298#discussion_r1220484149