On Sun, 25 Jun 2023 06:58:14 GMT, Doug Simon <dnsi...@openjdk.org> wrote:
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
The eager loading seems reasonable, but I do not understand the details here.
In what way was loading failing? You still have to initialize `VMSupport`
before you can call methods on it, so that could also fail - though the code
does not seem to notice/handle this. ??
src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 585:
> 583:
> 584: if (class_name->utf8_length() <= 1) {
> 585: JVMCI_THROW_MSG_0(InternalError, err_msg("Primitive type %s should
> be handled in Java code", str));
Seems unrelated to the fix at hand.
-------------
PR Review: https://git.openjdk.org/jdk/pull/14641#pullrequestreview-1497840467
PR Review Comment: https://git.openjdk.org/jdk/pull/14641#discussion_r1241749015
