On Thu, 29 Jun 2023 14:34:06 GMT, Frederic Parain <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fred's comments.
>
> src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp line 399:
>
>> 397: int length = sizeof(u2); // num_bootstrap_methods
>> 398: for (int n = 0; n < num_bootstrap_methods; n++) {
>> 399: int num_bootstrap_arguments = cpool()->operand_argument_count_at(n);
>
> operand_arguments_count_at() returns an u2, I think it would make more sense
> to put the cast line 402 where num_bootstrap_arguments is used.
I fixed both things you noticed. Thank you!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14710#discussion_r1246923278
