On Tue, 11 Jul 2023 19:56:25 GMT, Ashutosh Mehra <d...@openjdk.org> wrote:
>> Please review this PR that enables ClassWriter to write annotations to the >> class file being dumped. >> >> The fields annotations are stored in `Annotations::_fields_annotations` >> which is of type `Array<Array<u1>*>`. There is no class in SA that can >> represent it. I have added ArrayOfU1Array to correspond to the type >> `Array<Array<u1>*>` and it works. I believe there are better approaches but >> that would require a bit more refactoring of the classes representing Array >> types. I will leave that for future work for now. >> >> Testing: `test/hotspot/jtreg/serviceability/sa` and >> `test/jdk/sun/tools/jhsdb` >> Tested it manually by dumping j.l.String class and comparing the annotations >> with the original class using javap. >> The test case mentioned in >> [JDK-8311101](https://bugs.openjdk.org/browse/JDK-8311101) would provide >> better coverage. > > Ashutosh Mehra has updated the pull request incrementally with one additional > commit since the last revision: > > Some code motion and factoring out common code > > Signed-off-by: Ashutosh Mehra <asme...@redhat.com> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstMethod.java line 641: > 639: // | | > 640: // V V > 641: // | ... | default | type | parameter | method | So the `...` part is represented by `getSize()`? It would be good to call that out. Also point out that each of the annotations pointers is optional. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14735#discussion_r1260251805
