On Wed, 12 Jul 2023 06:11:04 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: removed unneeded @compile commands from new test > > test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTLSTest/VThreadTLSTest.java > line 29: > >> 27: * @requires vm.continuations >> 28: * @requires vm.jvmti >> 29: * @compile VThreadTLSTest.java > > I believe that this line is redundant. jtreg compiles test automatically. Yes. I forgot to remove it. :) > test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTLSTest/VThreadTLSTest.java > line 39: > >> 37: * @requires vm.continuations >> 38: * @requires vm.jvmti >> 39: * @compile VThreadTLSTest.java > > I believe that this line is redundant like 29. Yes. I forgot to remove it. :) Fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14842#discussion_r1260756205 PR Review Comment: https://git.openjdk.org/jdk/pull/14842#discussion_r1260757587