On Thu, 13 Jul 2023 17:40:47 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:

>> src/hotspot/share/runtime/trimNativeHeap.cpp line 47:
>> 
>>> 45: 
>>> 46:   // Statistics
>>> 47:   unsigned _num_trims_performed;
>> 
>> Sorry for the nit, but this is `uint16_t` too then, for consistency?
>
> No, since `_num_trims_performed` is the number of trims performed during the 
> lifetime of the JVM. It should probably bumped to 64-bit, now that we have 
> millisecond intervals.

Yeah, my patch, see the link above, does it as `uint64_t` :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14781#discussion_r1262879033

Reply via email to