On Fri, 14 Jul 2023 04:47:23 GMT, David Holmes <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Bikeshed Trim log lines
>
> src/hotspot/share/runtime/trimNativeHeap.cpp line 83:
>
>> 81:
>> 82: // in seconds
>> 83: static double now() { return os::elapsedTime(); }
>
> Do you need the wrapper for this rather than using `os::elapsedTime()`
> directly?
I rather keep it since it keeps the caller sites a bit better readable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14781#discussion_r1263332231
