On Tue, 25 Jul 2023 11:44:06 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this test-only change which removes usages of > the deprecated (no-op) `-Xdebug` from these tests? I missed these files when > addressing https://bugs.openjdk.org/browse/JDK-8227229. > > tier testing with these changes has passed without issues. Thank you David for the review. > Looks fine but what about > > ./runtime/CommandLine/TestNullTerminatedFlags.java > > I left this test untouched intentionally. The summary of that test says: > Test that the VM don't allow random junk characters at the end of valid > command line flags. Given that `-Xdebug` is still an accepted option, I think letting this test to continue running it against this option would be good. Once we completely remove that option, I think we can update this test. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15016#issuecomment-1651124186
