On Thu, 10 Aug 2023 17:01:30 GMT, Kevin Walls <[email protected]> wrote:

> Looks good to me, although do you think it could return null rather than 
> throw a RuntimeException? Concerned we might not always want the Tool to fail 
> and end there.

I chose throwing an exception, because this is what more commonly happens when 
you get a bad frame. You end up with some sort of AddressException, NPE, or a 
WrongTypeException while exploring garbage. See 
[JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800), especially the 
following comment:

> There are also other exceptions being thrown with similar stack traces (they 
> didn't cause the [JDK-8313798](https://bugs.openjdk.org/browse/JDK-8313798) 
> timeout because an exception was thrown instead of getting in an infinite 
> loop):

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15183#issuecomment-1673732561

Reply via email to