On Thu, 17 Aug 2023 16:56:39 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More fixes
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java
> line 90:
>
>> 88: printValMB("MaxMetaspaceSize = ",
>> getFlagValue("MaxMetaspaceSize", flagMap));
>> 89: if (heap instanceof G1CollectedHeap) {
>> 90: printValMB("G1HeapRegionSize = ",
>> HeapRegion.grainBytes());
>
> Nit: I'd suggest to move this line to the `G1CollectedHeap` specific block
> after line 123. It would be consistent with your change for
> `ShenandoahRegionSize`. Probably, the test needs to be updated to adopt to
> this tweak as well.
Thought about it, but decided that this thing is about the JVM flags, so kept
it as is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15328#discussion_r1297497721
