On Wed, 30 Aug 2023 22:57:00 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Test failed because of unexpected output of version string.
>> The standard convention for tests is to skip any unexpected output (version
>> string, VM warning, vm logging) and only fail on expected error patterns.
>> Fix is tested by running with default options and with '-showversion' vm
>> option.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> restore errorhandler
test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 110:
> 108: @Override
> 109: public void onStringRead(StreamHandler handler, String line) {
> 110: processDebuggeeOutput(line);
You might want to look at #4560, which added the onDebuggeeError() code, which
is no longer being called from anywhere after this change. @alexmenkov
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15499#discussion_r1310940852
