On Tue, 19 Sep 2023 00:03:27 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:

>> Please consider this fix for 
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds 
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it 
>> only handled `-Djava.net.preferIPv6Addresses=true` and 
>> `-Djava.net.preferIPv6Addresses=false`.
>
> Liam Miller-Cushon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Review feedback

test/jdk/com/sun/jdi/JdwpNetProps.java line 75:

> 73:                     .run(TestResult.Success);
> 74:             if (ipv6Address != null) {
> 75:                 // - only IPv4, so connection prom IPv6 should fail

Is there an existing typo here, I assume "prom" should be "from"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15796#discussion_r1329944069

Reply via email to