On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:

> Test start failing because of unexpected VM logging.
> The fix is to search expected string ignoring any unknown output from forked 
> process.
> Tested with tier1 and by running test with various options used in CI.

Okay - seems reasonable. One query.

Thanks

test/hotspot/jtreg/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java 
line 95:

> 93:                 } else {
> 94:                     System.out.println("Ignoring: " + pidstring);
> 95:                 }

Do we really want this in the test output?

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15833#pullrequestreview-1634681309
PR Review Comment: https://git.openjdk.org/jdk/pull/15833#discussion_r1331018776

Reply via email to