On Thu, 21 Sep 2023 00:49:45 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:

>> Please consider this fix for 
>> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds 
>> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it 
>> only handled `-Djava.net.preferIPv6Addresses=true` and 
>> `-Djava.net.preferIPv6Addresses=false`.
>
> Liam Miller-Cushon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add more test cases

test/jdk/com/sun/jdi/JdwpNetProps.java line 89:

> 87:                     .preferIPv4Stack(false)
> 88:                     .preferIPv6Addresses("true")
> 89:                     .run(TestResult.AttachFailed);

If test system is IPv4-only, this testcase will success
So it should be under "ipv6Address != null" section

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15796#discussion_r1333568399

Reply via email to