On Tue, 12 Sep 2023 22:24:18 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> This PR includes a couple of clarifications of the JDWP and JDI invoke method > support. The first is that deadlocks can occur due to a needed "resource" > being held. The spec previously just mentioned monitors being held, but this > is too specific. The second is to clarify that an invoke on a virtual thread > can be more prone to deadlocks than a platform thread may be. > > I did a doc build you can look at to view the changes. Links to the relevant > sections are below: > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/specs/jdwp/jdwp-protocol.html#JDWP_ClassType_InvokeMethod > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/specs/jdwp/jdwp-protocol.html#JDWP_ClassType_NewInstance > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/specs/jdwp/jdwp-protocol.html#JDWP_InterfaceType_InvokeMethod > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/specs/jdwp/jdwp-protocol.html#JDWP_ObjectReference_InvokeMethod > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/api/jdk.jdi/com/sun/jdi/ClassType.html#invokeMethod(com.sun.jdi.ThreadReference,com.sun.jdi.Method,java.util.List,int) > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/api/jdk.jdi/com/sun/jdi/ClassType.html#newInstance(com.sun.jdi.ThreadReference,com.sun.jdi.Method,java.util.List,int) > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/api/jdk.jdi/com/sun/jdi/InterfaceType.html#invokeMethod(com.sun.jdi.ThreadReference,com.sun.jdi.Method,java.util.List,int) > > https://cr.openjdk.org/~cjplummer/8301639/docs.01/api/jdk.jdi/com/sun/jdi/ObjectReference.html#invokeMethod(com.sun.jdi.ThreadReference,com.sun.jdi.Method,java.util.List,int) This pull request has now been integrated. Changeset: 9aaac2ee Author: Chris Plummer <cjplum...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/9aaac2eee34613c34b2800ddb4d42f5bbeba1837 Stats: 50 lines in 4 files changed: 36 ins; 0 del; 14 mod 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation Reviewed-by: dholmes, alanb ------------- PR: https://git.openjdk.org/jdk/pull/15695
