On Fri, 15 Dec 2023 19:43:36 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The fix updated JdwpAllowTest to test negative scenarios (debugger tries to > attach from not allowed address). > > MaskTest ctor incorrectly calculates prefix length for negative tests and > test main() calls `positiveTest` instead of `negativeTest` for > `prefixLengthBad`. > > Also fixes test output: > LingeredApp logs to System.out and the test logs to System.err, this makes > harder log analysis. Looks good. Nice comment about `bitToChange` values. ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17131#pullrequestreview-1785143379