On Tue, 2 Jan 2024 22:01:11 GMT, David Holmes <[email protected]> wrote:
>> Please review these missing updates to the `jcmd` manpage - see JBS issue >> for details. >> >> I also fixed the sub-command ordering in a few places and a couple of minor >> formatting fixes. >> >> Thanks to @tstuefe for collating the initial information on what was >> missing. I used to `jcmd help <cmd>` option to compare the help text with >> the manpage text and adjusted the manpage accordingly (and found a few more >> omissions - some of which will be fixed by follow up RFE by the respective >> owners). > > David Holmes has updated the pull request incrementally with one additional > commit since the last revision: > > Consistency pass to match manpage text with help text for VM subcommands src/jdk.jcmd/share/man/jcmd.1 line 199: > 197: .TP > 198: \f[V]Compiler.directives_add\f[R] \f[I]filename\f[R] \f[I]arguments\f[R] > 199: Adds compiler directives from a file. I might be misreading this one, it looks like there are two arguments but the the help output shows just one, maybe check that one. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17213#discussion_r1440134308
