On Fri, 5 Jan 2024 18:39:25 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
> Looks good. Q: Do you want to keep the debugging code under `#ifdef ... > #endif`? Yes. The "#ifdef DEBUG_THREADNAME" is something that I want the user to have to manually enable at build time to avoid the memory and performance impact. Also, "#if 0" code generates extra output that normally you don't want, but I wanted to leave the code there as examples and so it can be easily enabled when needed." > src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 2654: > >> 2652: jvmtiError error = FUNC_PTR(gdata->jvmti,GetThreadState) >> 2653: (gdata->jvmti, node->thread, &state); >> 2654: return state; > > Nit: The indent in this file is 4, not 2. Fixed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17259#issuecomment-1879132891 PR Review Comment: https://git.openjdk.org/jdk/pull/17259#discussion_r1443277177
