On Tue, 9 Jan 2024 23:48:35 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
> This fix adds a ResourceMark missing in the `SetFramePopClosure::do_thread` > and `SetFramePopClosure::do_vthread`. > > Testing: > - TBD to submit tiers: 1-5 Looks good. Note, it would be good if the jvmti code added comments explaining why a ResourceMark is needed. For these two cases I had to search around until I stumbled across the following in some unrelated code: // vframes are resource allocated Thread* current_thread = Thread::current(); ResourceMark rm(current_thread); This looks very much like the code you are updating, except the updated code is lacking the comment. ------------- Marked as reviewed by cjplummer (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17332#pullrequestreview-1812314880
