On Wed, 24 Jan 2024 21:01:37 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Some jvmti tests use
>> -Djava.util.concurrent.ForkJoinPool.common.parallelism
>> to control the pool of virtual threads. However, it is controlled by
>> jdk.virtualThreadScheduler.parallelism property.
>>
>> The non-continuations implementation doesn't use any of these properties and
>> it was just deleted.
>>
>> I verified the fix using jcmd Thread.dump and ran all jvmti tests in the
>> default configuration.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyrights years
This looks good but one test may still need an update?
test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/VThreadEventTest.java
line 210:
> 208:
> 209: }
> 210:
Does this test also need an update?
It has a line 32:
* -Djdk.virtualThreadScheduler.parallelism=9
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17547#pullrequestreview-1844041016
PR Review Comment: https://git.openjdk.org/jdk/pull/17547#discussion_r1466558265
