On Tue, 27 Feb 2024 01:27:54 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into >> 8318026_jcmd_VMdebug_command >> - Require UnlockDiagnosticVMOptions >> - Require >> UnlockDiagnosticVMOptionstest/hotspot/jtreg/serviceability/dcmd/vm/VMDebugTest.java >> - Tidy up the safety checks >> - Whitebox not required, just check option properties. >> - unnecessary parameter to find >> - Test update. Recognise ZGC oops differently. Formatting. >> - typo >> - Separate is_good_oop... method to avoid changing existing asserts. >> - More oop safety >> - ... and 1 more: https://git.openjdk.org/jdk/compare/add19854...f57f7274 > > src/hotspot/share/services/diagnosticCommand.cpp line 1245: > >> 1243: } >> 1244: } else if (strcmp("find", _subcommand.value()) == 0) { >> 1245: if (!UnlockDiagnosticVMOptions) { > > Would it make sense to require enabling `UnlockDiagnosticVMOptions` for all > sub-commands, so that it is clear this is not for live production use? Yes sure I've made that apply to all of them for consistency. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1507894462
