On Fri, 8 Mar 2024 02:35:08 GMT, Man Cao <m...@openjdk.org> wrote: >> Hi all, >> >> Could anyone review this fix to make serial heap dump only write to a single >> file? >> We highly appreciate the work in >> https://bugs.openjdk.org/browse/JDK-8306441. However, many of our customers >> still need to use serial heap dump, as they have limited disk space and need >> to dump to a network socket. >> >> Tested: >> Stress tested with a fastdebug build with tests in >> `hotspot/jtreg/serviceability/dcmd/gc/HeapDump*`. >> >> -Man > > Man Cao has updated the pull request incrementally with one additional commit > since the last revision: > > Fix failure under -XX:+UseSerialGC
The change seems reasonable and avoids some of the extra file overhead in the serial case. ------------- PR Review: https://git.openjdk.org/jdk/pull/18160#pullrequestreview-1923942056
