On Wed, 13 Mar 2024 09:49:19 GMT, David Holmes <dhol...@openjdk.org> wrote:
> As I wrote in JBS, shouldn't this be handled by `ThreadInVMfromNative`? (I wanted to publish the PR before answering your comment) This would be reasonable in my opinion. I've hoisted setting `WXWrite` mode in `JfrJvmtiAgent::retransform_classes()` because multiple instances of `ThreadInVMfromNative` are reached. This is likely not even necessary. Still exceptions could be made if there are usages of `ThreadInVMfromNative` where it is needed. While I agree I'd prefer to do it as a separate enhancement. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18238#issuecomment-1994000304
