On Sat, 9 Mar 2024 05:27:43 GMT, Leonid Mesnik <[email protected]> wrote:
>> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee. >> There is not need to start debugger in the separate process for each test. >> Also, no need to run it with "-Xcomp" because the main goal is to test >> debugee behavior with different VM flags. >> This fix updates tests to run debugger as driver to optimize execution time. >> The fix also eliminates System.exit() which is not compatible with >> driver/agentvm mode and update shared classes to correctly add classpath >> when running debugee. >> There were few tests which still execute using othervm mode. They require >> some specific classpath/settings. >> Tested by running all tests, with '-Xcomp' and virtual thread test factory. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > reverted failing tests. I agree there is a more general issue of test interference in anything other than `othervm` mode but that is beside the point. It seems to me that going from othervm to driver mode for the debugger has some not insignificant risk when it comes to interference. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18174#issuecomment-2002783668
