On Fri, 29 Mar 2024 13:29:15 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Thanks for the comments, Chris and Dan. Updated as Chris suggested. I've >> added this with `-Xcomp` consideration as the worst case scenario in mind. >> Now, I think it is more save to make it 10 seconds instead of one. Is it >> going to be good enough? In fact, I've added this for manual testing to save >> time in waiting for test completion when it is deadlocked. Also, this is >> better for diagnosability. > > runtime/8176717/TestInheritFD.java has an example of what I'm talking about: > > public static float timeoutFactor = > Float.parseFloat(System.getProperty("test.timeout.factor", "1.0")); > public static long subProcessTimeout = (long)(15L * timeoutFactor); > > so you fetch the test.timeout.factor value and then you scale your delay > value. > > Also: > > nit typo: s/waitig/waiting/ Thank you for the example and for catching the typo. The timeout factor also needs to be passed to the native side. I think, this fragment is not worth this kind of extra complexity. One approach would be to just make it big enough, eg. make it 100 seconds instead of 10. Another - to get rid of this trap at all. What would you prefer? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1544855730