On Thu, 11 Apr 2024 16:26:51 GMT, Patricio Chilano Mateo <pchilanom...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: refactored to get rid of overloaded doit functions > > src/hotspot/share/prims/jvmtiEnvThreadState.cpp line 367: > >> 365: GetCurrentLocationClosure op; >> 366: JvmtiHandshake::execute(&op, &tlh, thread, thread_h); >> 367: > > Seems we are missing a JvmtiVTMSTransitionDisabler. Good question, thanks. The `JvmtiVTMSTransitionDisabler` is supposed to be installed in the caller's context if needed. However, it is not easy to make sure it is always the case. At least, I see a couple of contexts when the `JvmtiVTMSTransitionDisabler` is not being installed. But it is not clear if it is really needed there. Let me do some extra analysis there. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18630#discussion_r1561834120
