On Mon, 13 May 2024 10:16:36 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update mallocLimit.hpp > > src/hotspot/share/nmt/memflags.hpp line 30: > >> 28: #include "utilities/globalDefinitions.hpp" >> 29: >> 30: #define MEMORY_TYPES_DO(f) >> \ > > Open-ended comment/question: We call it MEMORY_TYPE and mt, but then we call > the type MEMFLAGS (with a completely non-standard UPPERCASE style). Maybe it > is time to rename MEMFLAGS? I don't feel like starting that particular bike shedding discussion :) But sure, sometime in the future we should do this. Here, I want it to be a simple renaming change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19172#discussion_r1598580049
