On Tue, 14 May 2024 22:19:19 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The nsk.share.Log doing some cleanup and reporting errors in the cleanup >> method. This method is supposed to be executed by finalizer originally. >> However, now it is called only during shutdown hook. >> The cleanup using Cleaner doesn't work. See >> https://bugs.openjdk.org/browse/JDK-8330760 >> >> The cleanup() method flush stream and print summary which should be already >> printed by complain method. >> >> This cleanup is not necessary and printing summary usually is just disabled. >> It is enabled if the test called 'complain' method. However, the error >> should have been printed already in this method. >> >> So it would be simple to remove this cleanup and reduce usage of Finalizable >> in vmTestbase tests. >> >> Note: The 'verboseOnErrorEnabled' is just not used. >> >> See isVerboseOnErrorEnabled. >> >> public boolean isVerboseOnErrorEnabled() { >> return errorsSummaryEnabled; >> } >> >> >> Tested with by running tests with different combinations (tier4-7) and tier1. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fixed after comments Marked as reviewed by cjplummer (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19209#pullrequestreview-2056579895
