On Fri, 17 May 2024 03:49:21 GMT, Quan Anh Mai <qa...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: corrected the nullptr clarification > > src/hotspot/share/prims/jvmti.xml line 1007: > >> 1005: explicitly deallocate. This is indicated in the individual <jvmti/> >> 1006: function descriptions. Empty lists, arrays, sequences, etc are >> 1007: returned as a null pointer (C <code>NULL</code> or C++ >> <code>nullptr</code>). > > This may be a little unnecessary rigor, but I believe that `nullptr` is not a > null pointer. `nullptr` is the pointer literal that can be implicitly > converted to a null pointer value of any pointer type and any pointer to > member type. And I think the thing returned here is a null pointer, not > `nullptr`. I'm not sure I understand this comment. Sorry. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19257#discussion_r1625430986
