On Mon, 10 Jun 2024 08:35:06 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> @dholmes-ora this is one of yours. >> >> This was a tad annoying to fix (fix is simple though), since the jcmd >> framework has no good way to allow for default parameters that are not used >> literally. E.g. in this case, the real value for the file name will contain >> the process pid, which of course cannot be hard-coded. >> >> New output: >> >> >> Syntax : System.dump_map [options] >> >> Options: (options must be specified using the <key> or <key>=<value> syntax) >> -H : [optional] Human readable format (BOOLEAN, false) >> -F : [optional] file path (STRING, vm_memory_map_<pid>.txt) > > Looks good to me, yes non-literal defaults are a bit awkward here. Thanks @kevinjwalls, @dholmes-ora ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/19596#issuecomment-2157761743
