On Tue, 11 Jun 2024 07:57:59 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> I think the presentation of the carrier the mounted virtual thread in update >> (b122cc05) looks quite good. >> >> I think it would be helpful to include the thread name too. Many virtual >> threads are unnamed so it will show as "" but that is okay. In addition to >> being useful it means the format of the "Mounted virtual thread ..." line >> will be consistent the first part of the line for platform threads. >> >> I'm wondering if we should remove the existing "Carrying virtual thread ..." >> line as part of this. It's redundant now, @pron ? > >> @AlanBateman @dholmes-ora would you be OK with leaving the current PR as-is >> and handling the indentation topic in a separate PR ? > > I assume the follow-up to improve the alignment will be a small change. No > objection if you do it here or in a follow-up PR. Thanks @AlanBateman for your review ! I've incorporated your suggestions and it's ready to be reviewed again. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19482#issuecomment-2160283400
