> The nsk.share.Log has 3 parameters that might be configured by tests or > using command-line: > - verbose, traceLevel and timestamp > > The main purpose of these modes was to minimize output and use command-line > arguments to enable them during bug reproducing/debugging for vmTestbase when > it was compiled separately. > > However, such an approach has several disadvantages: > -- For intermittent issues, there is no all data in the logs > -- The enabling log might affect test behavior > -- No easy way to set these command-line options for jtreg tests > -- When verbose mode is disabled the messages are saved in some buffer and > printed only test complains. The mode causes issues if the test fails without > complaining (exception, crash, etc). The messages are just never printed. > -- the solution is over-complicated. > > The fix enabled verbose mode and printing time stamps always, setting the > debugging log level. > > The plan is to remove all these options and simplify logging as much as > possible in the future.
Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: the unused code removed ------------- Changes: - all: https://git.openjdk.org/jdk/pull/19613/files - new: https://git.openjdk.org/jdk/pull/19613/files/0434e815..8a966242 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19613&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19613&range=02-03 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19613.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19613/head:pull/19613 PR: https://git.openjdk.org/jdk/pull/19613
