On Fri, 14 Jun 2024 19:51:29 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> The vmTestbase/vm/share is a shared test library for vmTestbase tests. This >> library contains a lot of code that is used by only by small number of tests >> or not used at all. There are no plans to actively develop new tests in >> vmTestsbase and improve this shared library. >> The final goal of this and the following PRs is to reduce the maintenance >> cost of vmTestbase by eliminating this library. >> >> Also, this PR moves test-specific code into corresponding test directories >> to increase code locality. This allows later easier move tests from >> vmTestbase. >> >> The few remaining classes include >> InMemoryJavaCompiler.java >> that is very similar to same class from the standard testlibrary and could >> be merge with it and >> ProcessUtils.java >> which is used by >> test/hotspot/jtreg/runtime/Thread/TestBreakSignalThreadDump.java >> and thus should be moved into the standard testlibrary. >> The stack and options might be merged in nsk/share test library. > > test/hotspot/jtreg/vmTestbase/vm/compiler/complog/share/LogCompilationTest.java > line 32: > >> 30: import vm.share.options.Option; >> 31: import vm.share.options.OptionSupport; >> 32: import vm.share.process.ProcessExecutor; > > You got rid of this import, but ProcessExecutor is still referenced below. Is > this file even referenced during test execution? The ProcessExecutor has been moved into this package, so it is local package now. Double checked that it is used and tests jtreg:open/test/hotspot/jtreg/vmTestbase/vm/compiler/complog still pass. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19727#discussion_r1640299885
