On Mon, 22 Jul 2024 14:41:16 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comment
>
> test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMapTest.java line 124:
>
>> 122: OutputAnalyzer output = new
>> JMXExecutor().execute("Compiler.perfmap %s".formatted(path));
>> 123: output.shouldContain("Failed to create nonexistent/%s for
>> perf map".formatted(test_dir));
>> 124: output.shouldNotHaveExitValue(0);
>
> I'm curious if this exit value check works, as jcmd failures like this show
> "Command executed successfully" and return 0 for success.
> These compiler tests have chosen JMXExecutor and PidJcmdExecutor which might
> be relevant. Interested to know if JMXExecutor returns a non-zero exit value
> for this?
Hi Kevin,
Yes, I noticed the test was exiting with a non-zero value when I was testing.
After giving it a bit more thought, that check is not the main purpose of the
test and I'm not entirely sure why the JMXExecutor behaves that way. I'll just
remove the exit value check to avoid confusion.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20257#discussion_r1686750734
