On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`. > > `MEMFLAGS` implies that we can use more than one at the same time, but those > are exclusive values, so `MemType` is much more suitable name. > > There is a bunch of other related cleanup that we can do, but I will leave > for follow up issues such as [NMT: rename NMTUtil::flag to > NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836) Taking Dan's feedback into account we have: | | MemType | MemTypeFlag | NMTCat | NMTGroup | NMT_MemType | NMT::MemType | | :---: | :---: | :---: | :---: | :---: | :---: | :---: | | gerard | 1 | 0 | 0 | 0 | 2 | 3 | | David | 0 | 3 | 0 | 0 | 1(NMTMemType) | 2 | | Thomas | 0 | 0 | 2 | 3 | 0 | 0 | | Johan | 0 | 0 | 2(NMTCategory) | 3 | 0 | 0 | | Afshin | 0 | 3 | 0 | 0 | 0 | 2 | | Coleen | 0 | 0 | 0 | 0 | 0 | 3 | | Dan | 0 | 0 | 0 | 0 | 2(NMTMemType) | 3 | | | 1 | 6 | 4 | 6 | 5 | 13 | `NMT::MemType` it is. Sorry, if your choice hasn't made it. I am surprised how wide the spectrum of choices are, this took a while to find a consensus. Thank you everyone, who participated! ------------- PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2318083570
